Skip to content

Meta: Optimize PR warning insertion #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 1, 2025
Merged

Meta: Optimize PR warning insertion #24

merged 1 commit into from
Jan 1, 2025

Conversation

gibson042
Copy link
Collaborator

  • Use more specific error types.
  • For compatibility, switch from import(jsonFileName) to JSON.parse(readFile(jsonFileName)).
  • For performance, rather than parsing HTML into a complete AST, use a streaming rewriter (and switch to passthrough after prepending to <body>).

@gibson042
Meta: Optimize PR warning insertion
3991343 
* Use more specific error types.
* For compatibility, switch from `import(jsonFileName)` to
  `JSON.parse(readFile(jsonFileName))`.
* For performance, rather than parsing HTML into a complete AST, use a
  streaming rewriter (and switch to passthrough after prepending to
  `<body>`).
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 1, 2025

The rendered spec for this PR is available at https://tc39.es/proposal-immutable-arraybuffer/pr/24.

@gibson042 gibson042 merged commit 04b49a7 into tc39:main Jan 1, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@gibson042